-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list shows in json format #662
Open
RaitaroH
wants to merge
10
commits into
z411:master
Choose a base branch
from
RaitaroH:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c1d6c1e
list shows without formatting
RaitaroH 0b1137e
print name of show only
RaitaroH c5483bc
print json format
RaitaroH 95da160
remove name funciton
RaitaroH 27a07c0
total_episodes key
RaitaroH dbd4a22
ignore altnames
RaitaroH b4ae65b
airing and behind status
RaitaroH 108fbf2
Update cli.py
RaitaroH 5a200d9
estimate episode as string
RaitaroH 2b681ba
also print cover image
RaitaroH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should mention that each entry is printed as a JSON line on its own (instead of an array). At least right now.
If we were to consider things like the scoring format, it may be useful to also report that in a meta object on its own, in which case the question follows whether the entries should instead be wrapped in an array to build an object as follows:
I don't now how the scoring format options in anilist are implemented currently in various parts of the code or whether it makes more sense to instead specify a
max_score
to be of either 3, 5, or 10 (and use the latter for 10, 20, and 100-point schemas).And that it is intended to be used by third-party tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my particular usage, each entry being on its own line is better. In case another shell program wants to use this, I think it might be better to leave it like this.
The scoring format is something I was simply wondering about, but I think is a good idea to investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this unresolved for @z411 to read (also the description hasn't been updated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind reminder.
@z411