-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
list shows in json format #662
base: master
Are you sure you want to change the base?
Conversation
for issue z411#660
Apologies if this isn't quite correct / good. I don't know python that much. |
faster than info
@@ -362,6 +365,39 @@ def do_list(self, args): | |||
# Show the list in memory | |||
self._make_list(self.sortedlist) | |||
|
|||
def do_list_json(self, args): | |||
""" | |||
Print list of shows in json format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should mention that each entry is printed as a JSON line on its own (instead of an array). At least right now.
If we were to consider things like the scoring format, it may be useful to also report that in a meta object on its own, in which case the question follows whether the entries should instead be wrapped in an array to build an object as follows:
{ "account": "string", "api": "string", "has_progress": false, "scoring_format": "enum", "entries": [{…}] }
I don't now how the scoring format options in anilist are implemented currently in various parts of the code or whether it makes more sense to instead specify a max_score
to be of either 3, 5, or 10 (and use the latter for 10, 20, and 100-point schemas).
And that it is intended to be used by third-party tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my particular usage, each entry being on its own line is better. In case another shell program wants to use this, I think it might be better to leave it like this.
The scoring format is something I was simply wondering about, but I think is a good idea to investigate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this unresolved for @z411 to read (also the description hasn't been updated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind reminder.
@z411
reverts 0b1137e
Co-authored-by: FichteFoll <[email protected]>
this should be useful in my adl script
For issue #660
If you merge this PR, please squash and merge.
Example of
trackma list_json
(it defaults to watching list)Then it also can accept list status,
trackma list_json paused
:I believe
trackma -a
should work. I tested withtrackma -a 2 list_json
and it asks me to select account first, before listing anything.In bash scripts,
jq
works as expected. Here is a more complicated command: