Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify converter to allow setting values for object and array #678

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

chacha912
Copy link
Contributor

@chacha912 chacha912 commented Nov 20, 2023

What this PR does / why we need it:

This PR is associated with yorkie-team/yorkie-js-sdk#691. Since modifications have been made to allow setting values in set and add operations, it is necessary to update the converter accordingly. This involves enabling the setting of values for objects and arrays in the converter.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Additional documentation:


Checklist:

  • Added relevant tests or not required
  • Didn't break anything

@chacha912 chacha912 requested a review from hackerwins November 20, 2023 16:27
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (5500afb) 48.96% compared to head (a85ff4b) 48.92%.

Files Patch % Lines
api/converter/from_bytes.go 30.76% 6 Missing and 3 partials ⚠️
api/converter/to_bytes.go 40.00% 4 Missing and 2 partials ⚠️
api/converter/to_pb.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   48.96%   48.92%   -0.05%     
==========================================
  Files          69       69              
  Lines       10090    10111      +21     
==========================================
+ Hits         4941     4947       +6     
- Misses       4631     4641      +10     
- Partials      518      523       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins added protocol changed 📝 Whether the protocol has changed and removed protocol changed 📝 Whether the protocol has changed labels Nov 21, 2023
Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@hackerwins hackerwins merged commit 7069678 into main Nov 21, 2023
2 checks passed
@hackerwins hackerwins deleted the set-nested-object branch November 21, 2023 10:57
@hackerwins
Copy link
Member

This PR triggers the following regression error. It has been excluded from main branch for now.
https://github.com/yorkie-team/yorkie-js-sdk/actions/runs/6952009135/job/18914902200#step:9:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants