Modify converter to allow setting values for object and array #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
==========================================
- Coverage 48.96% 48.81% -0.15%
==========================================
Files 69 69
Lines 10090 10127 +37
==========================================
+ Hits 4941 4944 +3
- Misses 4631 4657 +26
- Partials 518 526 +8 ☔ View full report in Codecov by Sentry. |
hackerwins
approved these changes
Nov 23, 2023
hackerwins
pushed a commit
that referenced
this pull request
Nov 23, 2023
PR#678 triggers the regression error, so I made corrections and re-submitted. I've added handling for cases where values are not set when converting to PbJSONElementSimple. In the bytesToObject function, It was previously creating a new object with initialTicket when the bytes were nil. However, this logic became inappropriate after separating it from bytesToSnapshot, so I removed it.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PR#678 triggers the regression error, so I made corrections and re-submitted. I've added handling for cases where values are not set when converting to
PbJSONElementSimple. In thebytesToObjectfunction, It was previously creating a new object with initialTicket when the bytes were nil. However, this logic became inappropriate after separating it frombytesToSnapshot, so I removed it.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation:
Checklist: