Database test updates #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
11 tasks
toasted-nutbread
force-pushed
the
database-test-updates2
branch
from
22e71e2 to
81e71f2
Compare
djahandarie
approved these changes
Dec 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the database.tests.js file to be a little bit more idiomatic for vitest and it moves the test case data into a JSON file. This should make it a little bit easier to distinguish between PRs where "a new type of test was added" vs "a new test case was added or changed", since the latter will only need to modify the JSON. This fixes some issues with nested tests also.
#434 should probably be merged first, as it updates the test data, which I can subsequently update.