Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests should be updated to be more idiomatic for vitest #472

Closed
11 tasks done
toasted-nutbread opened this issue Dec 27, 2023 · 0 comments · Fixed by #677
Closed
11 tasks done

Tests should be updated to be more idiomatic for vitest #472

toasted-nutbread opened this issue Dec 27, 2023 · 0 comments · Fixed by #677
Assignees

Comments

@toasted-nutbread
Copy link

toasted-nutbread commented Dec 27, 2023

I've done some work on this in #461, #415, #363, etc. but a lot of the tests are not idiomatic for how vitest likes tests. I know this is because they were converted from the way I did tests in Yomichan, which was largely without a framework, but it would be useful to seem them get a full update to how vitest usually describes tests.

This would also help avoid issues where tests might silently not be working as expected such as #363, and could help encourage contributors to add more tests as there would be better code to reference.

Remaining files:

  • test/cache-map.test.js
  • test/core.test.js
  • test/css-json.test.js
  • test/hotkey-util.test.js
  • test/japanese-util.test.js
  • test/json-schema.test.js
  • test/language-transformer.test.js
  • test/object-property-accessor.test.js
  • test/options-util.test.js
  • test/profile-conditions-util.test.js
  • test/text-source-map.test.js
This was referenced Jan 2, 2024
@toasted-nutbread toasted-nutbread self-assigned this Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant