Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template helper function improvements #439

Conversation

toasted-nutbread
Copy link

Fixes #437. Was due to the different modalities that helpers can be used in:

The following would work:

{{~#*inline "test"~}}
    {{~#scope~}}
        {{~#regexMatch "test" "gu"~}}test{{~/regexMatch~}}
    {{~/scope~}}
{{~/inline~}}
{{~> (lookup . "marker") ~}}

The following would not work:

{{~#*inline "test"~}}
    {{~#scope~}}
        {{~set "value" (regexMatch "test" "gu" "test")}}
    {{~/scope~}}
{{~/inline~}}
{{~> (lookup . "marker") ~}}

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner December 24, 2023 16:41
Copy link

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@djahandarie djahandarie added this pull request to the merge queue Dec 25, 2023
Merged via the queue into yomidevs:master with commit 83ebc13 Dec 25, 2023
5 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JP Mining Note template render error on latest
2 participants