Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Yomichan migration docs to reflect the changes to regexMatch handlebars #531

Closed
arbyste opened this issue Jan 16, 2024 · 1 comment · Fixed by #535
Closed
Labels
kind/bug The issue or PR is regarding a bug

Comments

@arbyste
Copy link

arbyste commented Jan 16, 2024

Description
It looks like the upgrade to Version 23.12.29.0 changed the way that the handlebars uses regexMatch. The following quote is from this pull request for JPMN: arbyste/jp-mining-note#4

The problem is that regexMatch no longer works in the form {{regexMatch regex [flags] [text-to-modify]...}}.
Instead, it only works in the form {{#regexMatch regex [flags]}}text-to-modify{{/regexMatch}}. Maybe an issue should be raised in Yomitan?

Was this change intentional? I couldn't see anything about it in the release notes for 23.12.29.0. If this behavior is expected, then perhaps it would be a good idea to add it to the Yomichan migration docs? (https://github.com/themoeway/yomitan/blob/master/docs/yomichan-migration.md)

Yomitan version
23.12.29.0

@arbyste arbyste added the kind/bug The issue or PR is regarding a bug label Jan 16, 2024
@Casheeew
Copy link
Member

Seems like it should be handled by this pr #439 . @toasted-nutbread thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug The issue or PR is regarding a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants