-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type annotations #339
Type annotations #339
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
Insanely impressive. Thank you so much. Once the CI failure is fixed, assuming the tests pass I think we can just merge it 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!!
@toasted-nutbread I noticed that this PR doesn't add the test-ts check to CI. I was going to put it into CI myself, but then I noticed that tsc is actually failing for me locally:
Does this happen in your environment? |
Oh good point, I didn't realize that the CI wasn't just running Regenerate your files in ext/lib, I made a change which adds a |
This change adds JSDoc type annotations to everything and fixes any relevant code/bugs that arose due to incorrect type handling.
This is a massive change and I have not verified that everything 100% works as it should, but some cursory testing appears okay.