Change no-console to error, only for ext files #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Thanks! I think we should write down some sort of standard/policy regarding when it's appropriate to console in extension code. I feel like most things should go through the logger instead. Maybe the existing cases of direct console usage are acceptable for some reason, but I don't think it's immediately clear what that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally mentioned here: #339 (comment)
I believe warnings are not useful information as they can (and by some people, will) deliberately be ignored, and they add a bunch of messages that are unrelated to the current working feature branch when running the test.
IMO this should be enforced as an error, and any existing locations with this problem should be explicitly annotated in the code to allow them so that they don't show up in future reports. They should really also only apply to the
extfolder, as the dev/test stuff is command line stuff that should be expected to write to console.