Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave url field blank when creating cards from search page #1685

Merged
merged 7 commits into from
Dec 23, 2024
Merged

Leave url field blank when creating cards from search page #1685

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a78eed2
Add empty string to field if url starts with chrome-extension or moz-…
dchen5022 Dec 21, 2024
12b5918
Check for external protocl value instead
dchen5022 Dec 21, 2024
18ec1e8
Change url field in unit tests to empty string
dchen5022 Dec 21, 2024
3eb1b84
Check if url protocl matches window's protocol
dchen5022 Dec 22, 2024
e6d9d57
Fix unit tests
dchen5022 Dec 22, 2024
bc16903
Use slice instead of replaceAll
dchen5022 Dec 22, 2024
bfb2d78
Remove url from context before rendering templates
dchen5022 Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ext/js/data/anki-note-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ export class AnkiNoteBuilder {
}
}

// Make URL field blank if URL source is Yomitan
if (URL.canParse(context.url) && new URL(context.url).protocol === new URL(import.meta.url).protocol) {
context.url = '';
}

const commonData = this._createData(dictionaryEntry, mode, context, resultOutputMode, glossaryLayoutMode, compactTags, media, dictionaryStylesMap);
const formattedFieldValuePromises = [];
for (const [, fieldValue] of fields) {
Expand Down
Loading