Leave url field blank when creating cards from search page

[dchen5022]

Fixes #1558

Not sure how to add tests or if its necessary

[Kuuuube]

Does this work on edge? They have a different prefix registered but can't test this myself.

[jamesmaa]

Edge looks to be extension

And also for e-readers/android the url is kiwi-extension://

[Kuuuube]

I'd recommend using a similar approach to this instead

yomitan/ext/js/pages/settings/popup-preview-controller.js

Line 127 in 22da9df

return !!(url && url.includes('popup-preview.html') && !['http:', 'https:', 'ws:', 'wss:', 'ftp:', 'data:', 'file:'].includes(new URL(url).protocol));

.

[djahandarie]

Another option is to do something similar to the second half (after the &&) of this:

yomitan/ext/js/application.js

Line 199 in 3622197

const backendPort = (!('serviceWorker' in navigator)) && window.location.protocol === new URL(import.meta.url).protocol ?

Which checks if the URL matches the protocol of import.meta.url (which will be chrome-extension or whatever is appropriate for the given browser). This seems a bit better than having a big list of protocols maybe?

@Kuuuube Do you have a preference?

[dchen5022]

That looks like a cleaner solution

[Kuuuube]

@Kuuuube Do you have a preference?

Didn't know that existed. Your idea sounds better.

[dchen5022]

Should I add a test case for this? I'm not sure if it's possible since the expected results are in plain JSON while the window location URL is platform-dependent.

[Kuuuube]

Taking a proper look at this, I feel like this is the wrong change to make. Why modify the url after it has been sent to handlebars?

Especially considering the replace (or slice) that needs to be done here (could also make an element and pull out the attribute but that seems bad too). And what if there's another handlebar in the future that needs to use the url? Checking for {url} isn't great either.

You could throw this in before commonData is set and it will handle this case before it even gets to the handlebars:

// Make URL field blank if URL source is Yomitan
if (URL.canParse(context.url) && new URL(import.meta.url).protocol === new URL(context.url).protocol) {
    context.url = '';
}

And if you really wanted to, stopping the empty anchor tag from being sent to anki is a simple handlebars change (it wouldn't display anything in anki regardless):

{{~#*inline "url"~}}
    {{~#if (op ">" definition.url.length 0)~}}
        <a href="{{definition.url}}">{{definition.url}}</a>
    {{~/if~}}
{{~/inline~}}

[dchen5022]

Thanks for the help! I'll fix that