Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove binary data setting description #1180

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: remove binary data setting description #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/containers/UserSettings/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"settings.language.option-english": "English",

"settings.binaryDataInPlainTextDisplay.title": "Display binary data in plain text",
"settings.binaryDataInPlainTextDisplay.description": "Available starting from version 24.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description now looks redundant, since current ydb versions are 24-1 and higher


"settings.invertedDisks.title": "Inverted disks space indicators",

Expand Down
6 changes: 0 additions & 6 deletions src/containers/UserSettings/settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
USE_PAGINATED_TABLES_KEY,
} from '../../utils/constants';
import {Lang, defaultLang} from '../../utils/i18n';
import {ClusterModeGuard} from '../ClusterModeGuard';

import type {SettingProps, SettingsInfoFieldProps} from './Setting';
import i18n from './i18n';
Expand Down Expand Up @@ -85,11 +84,6 @@ export const languageSetting: SettingProps = {
export const binaryDataInPlainTextDisplay: SettingProps = {
settingKey: BINARY_DATA_IN_PLAIN_TEXT_DISPLAY,
title: i18n('settings.binaryDataInPlainTextDisplay.title'),
description: (
<ClusterModeGuard mode="multi">
{i18n('settings.binaryDataInPlainTextDisplay.description')}
</ClusterModeGuard>
),
};

export const invertedDisksSetting: SettingProps = {
Expand Down
Loading