Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove binary data setting description #1180

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Aug 16, 2024

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
120 117 0 3 0

Bundle Size: ✅

Current: 78.83 MB | Main: 78.83 MB
Diff: 0.00 MB (-0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@@ -27,7 +27,6 @@
"settings.language.option-english": "English",

"settings.binaryDataInPlainTextDisplay.title": "Display binary data in plain text",
"settings.binaryDataInPlainTextDisplay.description": "Available starting from version 24.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description now looks redundant, since current ydb versions are 24-1 and higher

@artemmufazalov artemmufazalov force-pushed the binary-data-setting branch 2 times, most recently from d138c8a to 0e5ad93 Compare August 22, 2024 12:47
@artemmufazalov artemmufazalov marked this pull request as ready for review August 22, 2024 12:47
@artemmufazalov artemmufazalov merged commit ec46259 into main Aug 26, 2024
6 checks passed
@artemmufazalov artemmufazalov deleted the binary-data-setting branch August 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants