Kels7 wip make it work in the browser #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crosschainer
approved these changes
Feb 25, 2024
benjig123
suggested changes
Feb 26, 2024
dist/index.d.mts
Outdated
| sk: string; | ||
| vk: string; | ||
| sk: any; | ||
| vk: any; |
There was a problem hiding this comment.
Weird. I only formatted src/lib/wallet.ts with prettier v3.2.5 and built it. I did not even touch any of your tsup configs
src/lib/wallet.ts
Outdated
| }; | ||
| }; | ||
|
|
||
| return wallet(); |
There was a problem hiding this comment.
Looks like your autoformatter created diffs where there shouldn't be.
src/lib/wallet.ts
Outdated
| return { | ||
| sk: new Uint8Array(kp["secretKey"].slice(0, 32)), | ||
| vk: new Uint8Array(kp["secretKey"].slice(32, 64)), | ||
| }; |
duelingbenjos
requested changes
Feb 26, 2024
KELs7
commented
Feb 26, 2024
| const uint8Array: Uint8Array = new Uint8Array(buffer); | ||
| const hexArray: string[] = Array.prototype.map.call(uint8Array, (x: number) => ("00" + x.toString(16)).slice(-2)); | ||
| const hexString: string = hexArray.join(""); | ||
| return hexString | ||
| } |
There was a problem hiding this comment.
The issue for the any types was due to buf2hex not written properly in typescript. In the near future all functions in helper.ts should be rewritten in proper typescript
KELs7
commented
Feb 26, 2024
| const publicKey = bip32.getPublicKey(key, false).toString("hex"); | ||
| hdkey = hdkey.derive(derivationPath); | ||
| const privateKey = helpers.buf2hex(hdkey.privateKey); | ||
| const publicKey = helpers.buf2hex(hdkey.publicKey).slice(2); | ||
|
|
There was a problem hiding this comment.
buf2hex was used for getting the privateKey and publicKey in hex strings . But because buf2hex was not properly typed, it returned any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission: Update ed25519-hd-key to ed25519-keygen
Issue Description
The npm package
ed25519-hd-keycurrently cannot be run in the browser due to its dependency oncreate-hmac. This issue has been acknowledged and can be found in the ed25519-hd-key GitHub repository [1]. To address this limitation, the decision was made to replaceed25519-hd-keywith the packageed25519-keygen[2].Changes Made
To resolve the issue, the logic for
ed25519-hd-keyin thesrc/lib/wallet.tsfile has been replaced with the logic fored25519-keygen. This replacement ensures that the code can be executed in the browser without any dependency conflicts [2]. The changes can be found in the branchkels7-wip-make-it-work-in-the-browser)Benefits of Using ed25519-keygen
By switching to
ed25519-keygen, the following benefits are achieved:Pull Request Details
The pull request includes the following changes:
ed25519-hd-keywithed25519-keygenin thesrc/lib/wallet.tsfile.create-hmac.