interactive: change to ListView (1/7) #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshaaban01
requested review from
tobiasgrosser,
superlopuh,
compor,
math-fehr and
webmiche
|
Screenshot or it didn't happen :) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 88.92% 88.90% -0.02%
==========================================
Files 260 260
Lines 32088 32080 -8
Branches 4733 4735 +2
==========================================
- Hits 28535 28522 -13
- Misses 2861 2866 +5
Partials 692 692 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Nov 15, 2023
superlopuh
requested changes
Nov 15, 2023
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
superlopuh
approved these changes
Nov 17, 2023
|
@superlopuh All of the tests have passed for the last couple days, and then randomly this one failed: CI - Python-based Testing / build (3.10) (pull_request why? |
|
Looks like a bug in the CI, makes sense since PRs on top of this one pass, it happens sometimes, I just restarted it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a selection list, I have changed it to a list view. This allows us to apply the SAME pass multiple times instead of only being allowed to apply one pass type one time. This is also useful to introduce the condense button functionality (which was difficult to cleanly implement under the SelectionList set up).