interactive: add "clear passes button" (2/7) #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshaaban01
requested review from
tobiasgrosser,
superlopuh,
compor,
math-fehr and
webmiche
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dalia/condense #1789 +/- ##
==================================================
- Coverage 88.90% 88.88% -0.03%
==================================================
Files 260 260
Lines 32080 32032 -48
Branches 4735 4727 -8
==================================================
- Hits 28522 28472 -50
- Misses 2866 2867 +1
- Partials 692 693 +1 ☔ View full report in Codecov by Sentry. |
|
Should this be stacked on #1788? |
fixed, sorry! |
superlopuh
reviewed
Nov 15, 2023
xdsl/interactive/app.py
Outdated
| def clear_passes(self, event: Button.Pressed) -> None: | ||
| """Selected passes cleared when "Clear Passes" button is pressed.""" | ||
| self.current_selected_pass_list = () | ||
| # self.update_current_module() |
compor
approved these changes
Nov 15, 2023
superlopuh
reviewed
Nov 15, 2023
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
dshaaban01
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to clear passes to the gui.
disclaimer/ honesty: Sasha and I are in disagreement with the way I have manually called a function (he envisions everything to be reactive and done "automatically"so to speak), however in order to connect the two reactive variables, I have found that the location where I have manually called the function, perfectly links them.