Widget | Log Viewer - preview #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cogboard-app/src/main/kotlin/com/cognifide/cogboard/ssh/auth/SSHAuthData.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/ssh/auth/SSHAuthData.kt
Outdated
Show resolved
Hide resolved
cogboard-app/src/main/kotlin/com/cognifide/cogboard/ssh/auth/SSHAuthData.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| fun createCommand(): String { | ||
| val logLines = config.getString(CogboardConstants.Props.LOG_LINES) ?: "0" |
There was a problem hiding this comment.
Please use the overloaded getString method that uses the second parameter:
config.getString(CogboardConstants.Props.LOG_LINES, "0")
| connect(config) | ||
| } catch (e: JSchException) { | ||
| LOGGER.error(e.message) | ||
| vertx.eventBus().send(eventBusAddress, e) |
There was a problem hiding this comment.
Can we extract method here:
sendError(e)
|
|
||
| private fun initSSHSession(authData: SSHAuthData) { | ||
| jsch = JSch() | ||
| jsch.setKnownHosts("~/.ssh/known_hosts") |
There was a problem hiding this comment.
what does this line mean? - does it requires some configuration?
cogboard-app/src/main/kotlin/com/cognifide/cogboard/ssh/session/SessionStrategyFactory.kt
Outdated
Show resolved
Hide resolved
|
|
||
| class SSHKeyAuthSessionStrategy(jSch: JSch, authData: SSHAuthData) : SessionStrategy(jSch, authData) { | ||
| override fun initSession(): Session { | ||
| if (authData.password == "") { |
There was a problem hiding this comment.
Please use: import io.netty.util.internal.StringUtil.EMPTY_STRING
Fix/review 414
Added proper exception handling to react to errors #420
Comment on lines
87
to
88
| channel.inputStream = null | ||
| sshInputStream = channel.inputStream |
There was a problem hiding this comment.
I don't get this part: why do we set those nulls here?
Comment on lines
36
to
37
| BASIC -> config.getString(Props.PASSWORD) | ||
| SSH_KEY -> config.getString(Props.SSH_KEY) |
There was a problem hiding this comment.
You have created variables for this: lines 12, 14
LogsViewer - change logs generator permissions
#476 - LogsViewer - Changes on frontend
LogViewer | Fix copy button
Feature/448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is just a changes preview fro CR purposes
SP: 1