Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/review 414 #419

Merged
merged 1 commit into from
Nov 14, 2021
Merged

Fix/review 414 #419

merged 1 commit into from
Nov 14, 2021

Conversation

mprzypasniak99
Copy link
Collaborator

Description

Fixes after review from PR #414

Motivation and Context

#414

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • Automated functional tests have been added or modified to cover my changes (if applicable)
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Cogboard Contributor License Agreement.

@mprzypasniak99 mprzypasniak99 changed the base branch from master to enhancement/log-viewer-widget November 14, 2021 16:37
@janeksmielowski janeksmielowski merged commit b3bd8b4 into enhancement/log-viewer-widget Nov 14, 2021
@janeksmielowski janeksmielowski deleted the fix/review-414 branch November 14, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeksmielowski janeksmielowski janeksmielowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mprzypasniak99 @janeksmielowski