Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade compile and target sdk version to Android API 31 #12

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

fluiddot
Copy link

@fluiddot fluiddot commented Oct 4, 2022

Description

This PR is related to the upgrade effort to Android 12 in Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#5181. It basically updates all references of compileSdkVersion and targetSdkVersion parameters to use version 31.

Test plan

This update can be tested using the Gutenberg editor and the following PR: WordPress/gutenberg#44610.
The idea would be to run smoke testing on the demo project in order to check that there are no issues with Android 12.

@@ -30,7 +30,7 @@
"@react-native-community/eslint-config": "0.0.5",
"babel-jest": "^24.9.0",
"babel-plugin-module-resolver": "3.1.3",
"detox": "12.4.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the detox package because the installation process was failing due to incompatibilities with newer Xcode versions.

@fluiddot fluiddot marked this pull request as ready for review October 4, 2022 17:10
@jhnstn jhnstn self-requested a review October 5, 2022 13:35
Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via WordPress/gutenberg#44610
👍

@fluiddot fluiddot merged commit 9a0a1b4 into wp-fork Oct 13, 2022
@fluiddot fluiddot deleted the update/android-12 branch October 13, 2022 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants