[RNMobile] Upgrade compile and target sdk version to Android API 31 #44610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
|
I tested the demo project using a simulator and haven't found any issues. Looks like the editor is working nice with Android 12 🎊 . |
3 tasks
This was referenced Oct 4, 2022
Merged
fluiddot
commented
Oct 4, 2022
fluiddot
commented
Oct 4, 2022
packages/react-native-bridge/android/react-native-bridge/build.gradle
Outdated
Show resolved
Hide resolved
jhnstn
approved these changes
Oct 5, 2022
|
I noticed that the List block is not rendering the items properly (see attached screenshots). The interesting part is that I tried using the latest changes from Gutenberg
|
The issue is not related to Android 12 but using a newer version of
|
After debugging the issue, I realized that is not a bug per se but caused by the introduction of a new dimension value (reference) to control the vertical margin of blocks. By default the value is This has been fixed in fdc7cc8 by simply setting the value to |
42 tasks
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
fluiddot
force-pushed
the
rnmobile/upgrade-android-api-31
branch
from
4522c75 to
0e18084
Compare
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
What?
Upgrade
react-native-aztec,react-native-bridgeandreact-native-editorprojects to Android 12 (API 31).Why?
Google Play requires apps to update to Android 12 (API level 31) before 31 November 1, 2022.
How?
compileSdkVersionandtargetSdkVersionproperties of all Android projects have been updated to API 31.Additionally, the main activity of the demo Android demo project is now exported. This is a behavior change required when using Android 12 related to safer component exporting (reference).
The Android dependencies of forked repositories have been also updated to Android 12:
Testing Instructions
This change doesn't affect a specific area, hence to test it we should basically smoke test the editor and check that works as expected.
Screenshots or screencast
N/A