-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for VideoPress v5 #22602
Merged
Merged
Changes from 13 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7e4bed9
Update Gutenberg Mobile reference
ccc4615
Update Gutenberg Mobile reference
acf76f7
Update Gutenberg Mobile reference
7b322a1
Update Gutenberg Mobile reference
b671b7d
Update Gutenberg Mobile reference
ed159be
feat: Enable VideoPress v5 capability
74718a4
Update Gutenberg Mobile reference
560e462
fix: Limit v5 to sites with VideoPress enabled
4d298c3
Merge branch 'trunk' into gutenberg/support-for-videopress-v5
9273748
Update RELEASE-NOTES
dbc23e5
Merge branch 'gutenberg/support-for-videopress-v5' of github.com:word…
a1bf687
Expand site types that support VideoPress v5
1625ef4
Update Gutenberg Mobile reference
169bb21
Merge branch 'trunk' into gutenberg/support-for-videopress-v5
bf07e03
Update RELEASE-NOTES with "Jetpack-only" prefix
73071b9
Update Gutenberg Mobile reference
8eb6f02
Fix typo in config
d38dea8
Merge branch 'trunk' into gutenberg/support-for-videopress-v5
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -607,6 +607,8 @@ - (BOOL)supports:(BlogFeature)feature | |
return [self supportsTiledGallery]; | ||
case BlogFeatureVideoPress: | ||
return [self supportsVideoPress]; | ||
case BlogFeatureVideoPressV5: | ||
return [self supportsVideoPressV5]; | ||
case BlogFeatureFacebookEmbed: | ||
return [self supportsEmbedVariation: @"9.0"]; | ||
case BlogFeatureInstagramEmbed: | ||
|
@@ -733,6 +735,11 @@ - (BOOL)supportsVideoPress | |
return self.isHostedAtWPcom; | ||
} | ||
|
||
- (BOOL)supportsVideoPressV5 | ||
{ | ||
return self.isHostedAtWPcom || self.isAtomic || [self hasRequiredJetpackVersion:@"8.5"]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See related comment on Android PR for selecting this version number: https://github.com/wordpress-mobile/WordPress-Android/pull/20181/files#r1497916911 |
||
} | ||
|
||
- (BOOL)supportsEmbedVariation:(NSString *)requiredJetpackVersion | ||
{ | ||
return [self hasRequiredJetpackVersion:requiredJetpackVersion] || self.isHostedAtWPcom; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, since VideoPress v5 is a Jetpack block and it won't be available in the WP app, we should consider adding the prefix
[Jetpack-only]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in bf07e03, thanks!