Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for VideoPress v5 #22602

Merged
merged 18 commits into from
Feb 23, 2024
Merged

Initial support for VideoPress v5 #22602

merged 18 commits into from
Feb 23, 2024

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Feb 13, 2024 •
edited
Loading

Related PRs

To Test:

Please refer to the Jetpack PR as the central place for these changes, with the most up-to-date testing instructions.

Regression Notes

  1. Potential unintended areas of impact

    • This PR introduces changes to the way the Video block is rendered, as such there is a chance of unintended changes to that block. However, as we are re-using most of the block's existing code, the risk should be minimal.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manually went through existing test cases for the Video block.

  3. What automated tests I added (or what prevented me from doing so)

    • No tests were added, partly due to the current difficulty adding tests within the Jetpack repo. This an area I'd like to revisit at a future date.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@SiobhyB SiobhyB added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. labels Feb 13, 2024
This was referenced Feb 13, 2024
Merged
Merged
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 13, 2024 •
edited
Loading

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22602-d38dea8
Version24.3
Bundle IDorg.wordpress.alpha
Commitd38dea8
App Center BuildWPiOS - One-Offs #8966
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 13, 2024 •
edited
Loading

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22602-d38dea8
Version24.3
Bundle IDcom.jetpack.alpha
Commitd38dea8
App Center Buildjetpack-installable-builds #7996
 Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@SiobhyB SiobhyB changed the title [TESTING ONLY] Initial support for VideoPress v5 Initial support for VideoPress v5 Feb 17, 2024
@SiobhyB SiobhyB mentioned this pull request Feb 19, 2024
Merged
13 tasks
@SiobhyB SiobhyB marked this pull request as ready for review February 19, 2024 10:39
SiobhyB
SiobhyB commented Feb 21, 2024
View reviewed changes
WordPress/Classes/Models/Blog.m
@@ -733,6 +735,11 @@ - (BOOL)supportsVideoPress
return self.isHostedAtWPcom;
}

- (BOOL)supportsVideoPressV5
{
return self.isHostedAtWPcom || self.isAtomic || [self hasRequiredJetpackVersion:@"8.5"];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See related comment on Android PR for selecting this version number: https://github.com/wordpress-mobile/WordPress-Android/pull/20181/files#r1497916911

fluiddot
fluiddot approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

RELEASE-NOTES.txt Outdated
@@ -1,6 +1,6 @@
24.4
-----

* [**] Block editor: Introduce VideoPress v5 support, to fix issues using video block with dotcom and Jetpack sites [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6634]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, since VideoPress v5 is a Jetpack block and it won't be available in the WP app, we should consider adding the prefix [Jetpack-only].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in bf07e03, thanks!

@SiobhyB SiobhyB added this to the 24.4 milestone Feb 23, 2024
@SiobhyB SiobhyB merged commit 4ad3d59 into trunk Feb 23, 2024
21 checks passed
@SiobhyB SiobhyB deleted the gutenberg/support-for-videopress-v5 branch February 23, 2024 19:11
@derekblank derekblank mentioned this pull request Feb 28, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

@derekblank derekblank Awaiting requested review from derekblank

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks. Media
Projects
None yet
Milestone
24.4
Development

Successfully merging this pull request may close these issues.
3 participants
@SiobhyB @wpmobilebot @fluiddot