Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location handling cleanup #21527

Closed
wants to merge 24 commits into from

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Dec 13, 2024

This WIP PR takes care of "cleaning up" after switching to per-app language preferences. We had a lot of code to handle locale changes, but the system now handles all of that for us. Testing steps are the same as with previous PRs:

Test 1:

  • Run the app on a device using Android 13 or later
  • Go to App Settings and tap "Interface language"
  • Note that the system dialog for "App Language" appears instead of our own
  • Verify changing languages works

Test 2:

  • Perform the above with an older device and verify our own language dialog appears and changing languages works

Note: There is likely more cleaning up that can be done, but I didn't want to make this PR even larger that it already is.

@nbradbury nbradbury changed the base branch from trunk to feature/per-app-language-prefs December 13, 2024 13:37
@dangermattic
Copy link
Collaborator

dangermattic commented Dec 13, 2024

1 Warning
⚠️ This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 13, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21527-7256d66
Commit7256d66
Direct Downloadwordpress-prototype-build-pr21527-7256d66.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 13, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21527-7256d66
Commit7256d66
Direct Downloadjetpack-prototype-build-pr21527-7256d66.apk
Note: Google Login is not supported on these builds.

@nbradbury nbradbury changed the title Location handling cleanup Location handling cleanup, part one Dec 13, 2024
@nbradbury nbradbury changed the title Location handling cleanup, part one Location handling cleanup Dec 13, 2024
@nbradbury
Copy link
Contributor Author

This PR became too unwieldy so I'm closing it in favor of multiple smaller PRs.

@nbradbury nbradbury closed this Dec 13, 2024
@nbradbury nbradbury deleted the nick/location-manager branch December 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants