-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Location handling cleanup #21527
Closed
Closed
Location handling cleanup #21527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbradbury
changed the base branch from
trunk
to
feature/per-app-language-prefs
December 13, 2024 13:37
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
nbradbury
changed the title
Location handling cleanup
Location handling cleanup, part one
Dec 13, 2024
nbradbury
changed the title
Location handling cleanup, part one
Location handling cleanup
Dec 13, 2024
Quality Gate passedIssues Measures |
This PR became too unwieldy so I'm closing it in favor of multiple smaller PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP PR takes care of "cleaning up" after switching to per-app language preferences. We had a lot of code to handle locale changes, but the system now handles all of that for us. Testing steps are the same as with previous PRs:
Test 1:
Test 2:
Note: There is likely more cleaning up that can be done, but I didn't want to make this PR even larger that it already is.