Remove locale aware activity

[nbradbury]

As a follow up to #21521, this PR removes LocaleAwareActivity. There are a lot of files changed in this PR, but this was because we extended LocaleAwareActivity in so many places. In this PR, I changed them all to extend AppCompatActivity.

Testing steps are the same as the prior PR.

Test 1:

• Run the app on a device using Android 13 or later
• Go to App Settings and tap "Interface language"
• Note that the system dialog for "App Language" appears instead of our own
• Verify changing languages works

Test 2:

• Perform the above with an older device and verify our own language dialog appears and changing languages works

Note: There's still quite a bit of cleanup to do related to locale handling (unnecessary functions, etc.), but I wanted to keep this PR dedicated to removing LocaleAwareActivity. Cleanup is being addressed in this draft PR.

[dangermattic]

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21523-e7f0947
	Commit	e7f0947
	Direct Download	jetpack-prototype-build-pr21523-e7f0947.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21523-e7f0947
	Commit	e7f0947
	Direct Download	wordpress-prototype-build-pr21523-e7f0947.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.44%. Comparing base (c62e604) to head (e7f0947).
Report is 10 commits behind head on feature/per-app-language-prefs.

Additional details and impacted files

@@                       Coverage Diff                       @@
##           feature/per-app-language-prefs   #21523   +/-   ##
===============================================================
  Coverage                           39.44%   39.44%           
===============================================================
  Files                                2119     2119           
  Lines                               99556    99556           
  Branches                            15313    15313           
===============================================================
  Hits                                39269    39269           
  Misses                              56806    56806           
  Partials                             3481     3481           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ParaskP7]

👋 @nbradbury !

I have reviewed and tested this PR as per the instructions, everything works as expected, good job! 🌟

---

EXTRAS

About this Fixed detekt errors commit and the TODO: Xyz comment having its colon (:) character removed just to fixed Detekt complaining, I suggest keeping that colon (:) character, otherwise the TODO Xyz format is not the expected one. Instead, I suggest adding the @Suppress("ForbiddenComment") annotation to suppress this warning.

PS: Not related to this PR, but same applies to:

• ReaderPostNewViewHolder.loadVideoThumbnail(...) function (needs to suppress, it being a Kotlin class), and
• JobServiceId.isJobServiceWithSameParamsPending(...) method (need not to suppress, it being a Java class).

Them being the only other TODO I could find with the colon (:) character.

[nbradbury]

I suggest keeping that colon (:) character, otherwise the TODO Xyz format is not the expected one. Instead, I suggest adding the @Suppress("ForbiddenComment") annotation to suppress this warning.

@ParaskP7 Can you elaborate on this? I'm not sure why this would be an improvement.

[ParaskP7]

@ParaskP7 Can you elaborate on this? I'm not sure why this would be an improvement.

Sure @nbradbury , I have a few things on that:

1. Detekt is looking for TODO: Xyz and not TODO Xyz comments to report on violations (ForbiddenComment). This rules is supposed to help prevent such comments to enter the the codebase, and only be used during development.
2. From a quick search, the JP/WPAndroid codebase is mostly using TODO: Xyz, instead of TODO Xyz, so this helps with keeping some consistency.
3. I also personally prefer to use TODO: Xyz over TODO Xyz, because the colon (:) helps with creating a "correct" sentence, me starting with a TODO Xyz, FIXME Xyz, etc, feels to me a bit off. However, I understand this is totally a personal preference thing, and me getting used to this, over anything else.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ SQLiteBlobTooBigException: Row too big to fit into CursorWindow requiredPos=0, totalRows=1 org.wordpress.android.fluxc.persistence.EditorT... View Issue

_{Did you find this useful? React with a 👍 or 👎}