Removes multiple calls to the WebSettings.getDefaultUserAgent api

[antonis]

Fixes #12259

Description

This PR replaces multiple calls to the WebSettings.getDefaultUserAgent(which is not recommended) with just one, hoping to prevent the ANR of #12259 and probably reduce the crash count in #20147

The current implementation is making 27 calls to the WebSettings.getDefaultUserAgent function during the app startup and more later. One of those was in the AppInitialiser and the rest were calls to the AppConfigModule that uses the FluxC implementation.

Since I wasn't able to reproduce the ANR my plan is to monitor how this fix would affect the occurrences of the issue. If the issue persist I would probably try a more drastic approach of changing the user agent used for the api calls and keep the full user agent using the WebSettings.getDefaultUserAgent only for the WebViews.

Internal ref: pcdRpT-5Us-p2#comment-9676

---

To Test:

• Since this PR should not change the behaviour of the app but the refactored code affects all network calls a sanity check of the app is recommended.
• Test Jetpack and WordPress, rest and xmlrpc
• Verify that the AppInitializer.userAgentString is logged correctly

---

Regression Notes

1. Potential unintended areas of impact

   • All Networking 😅

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • Manual testing

3. What automated tests I added (or what prevented me from doing so)

   • Updated an existing test

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist (strike-out the not-applying and unnecessary ones):

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	1 Warning
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

[antonis]

Hey @irfano, @thomashorta 👋
I'm adding you as reviewers since you might have some context from previous work on the AppInitialiser. I plan to iterate on this PR next week and test it more before making it ready for review. Any early feedback is more than welcome 🙇

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20603-968cc5a
	Commit	968cc5a
	Direct Download	wordpress-prototype-build-pr20603-968cc5a.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20603-968cc5a
	Commit	968cc5a
	Direct Download	jetpack-prototype-build-pr20603-968cc5a.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 40.40%. Comparing base (d1577bb) to head (968cc5a).

Files	Patch %	Lines
.../main/java/org/wordpress/android/AppInitializer.kt	0.00%	3 Missing ⚠️
...rg/wordpress/android/ui/blaze/BlazeFeatureUtils.kt	0.00%	2 Missing ⚠️
...a/org/wordpress/android/ui/media/ExoPlayerUtils.kt	0.00%	2 Missing ⚠️
...i/sitecreation/plans/SiteCreationPlansViewModel.kt	0.00%	2 Missing ⚠️
...rdpress/android/ui/sitemonitor/SiteMonitorUtils.kt	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #20603   +/-   ##
=======================================
  Coverage   40.39%   40.40%           
=======================================
  Files        1474     1474           
  Lines       67920    67911    -9     
  Branches    11231    11230    -1     
=======================================
- Hits        27438    27437    -1     
+ Misses      38000    37992    -8     
  Partials     2482     2482           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[sentry-io]

Sentry Issue: JETPACK-ANDROID-P8V

[irfano]

Nice work! Thank you for implementing this change. I conducted a smoke test on the app, and everything seems to be in order. ✅ It makes sense to move the userAgent to a single place and make it Singleton in AppConfigModule. The diff looks safe to me. Feel free to merge the PR if you believe a single approval is sufficient.

[antonis]

Thank you for reviewing @irfano 🙇

Feel free to merge the PR if you believe a single approval is sufficient.

I'm not sure if this PR fixes the issue but I feel confident with the introduced changes and I'll proceed with merging. I'll monitor the 24.7 beta rollout for any unexpected side effects and to check if the fix worked.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.util.PackageUtils in getP... View Issue
• ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.fluxc.network.UserAgent i... View Issue
• ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.fluxc.network.UserAgent i... View Issue
• ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.fluxc.network.UserAgent i... View Issue
• ‼️ ApplicationNotResponding: Background ANR org.wordpress.android.fluxc.network.UserAgent i... View Issue

_{Did you find this useful? React with a 👍 or 👎}