Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes LongMethod detekt issue in AppInitializer.init method #20630

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Apr 12, 2024

Description

Fixes LongMethod Detekt issue in AppInitializer.init method introduced by merging #20603 and #20620 that both extended the method without merging from trunk.


To Test:

Verify that all CI tests are 🟢


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • Manual testing
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@antonis antonis added this to the 24.7 milestone Apr 12, 2024
@antonis antonis requested a review from geriux April 12, 2024 11:52
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 12, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.7. This milestone is due in less than 4 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@antonis antonis changed the title Fixes LongMethod detekt issue Fixes LongMethod detekt issue in AppInitializer.init method Apr 12, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antonis antonis marked this pull request as ready for review April 12, 2024 11:56
@antonis antonis enabled auto-merge April 12, 2024 11:56
Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20630-5f98281
Commit5f98281
Direct Downloadwordpress-prototype-build-pr20630-5f98281.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20630-5f98281
Commit5f98281
Direct Downloadjetpack-prototype-build-pr20630-5f98281.apk
Note: Google Login is not supported on these builds.

@antonis antonis merged commit d74131a into trunk Apr 12, 2024
26 checks passed
@antonis antonis deleted the fix/appinitialiserdetektissue branch April 12, 2024 12:21
Copy link

sentry-io bot commented Apr 12, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RuntimeException: Unable to create application org.wordpress.android.WordPressRelease: java.lang.SecurityException:... android.app.ActivityThread in handleBindApplica... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants