Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sans serif for notifications #20202

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Use sans serif for notifications #20202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f9cf5e
Use sans-serif in comment detail fragment
mkevins Feb 19, 2024
5468fd1
Use sans-serif font in note block and comment user note block
mkevins Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPress/src/main/java/org/wordpress/android/ui/notifications/blocks/NoteBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ public void onResourceReady(@NonNull Drawable resource, @Nullable Object model)
});
} else {
noteBlockHolder.getTextView().setTextSize(28);
TypefaceSpan typefaceSpan = new TypefaceSpan("serif");
TypefaceSpan typefaceSpan = new TypefaceSpan("sans-serif");
noteText.setSpan(typefaceSpan, 0, noteText.length(), Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);
}
}
Expand Down
2 changes: 1 addition & 1 deletion WordPress/src/main/res/layout/comment_detail_fragment.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
android:id="@+id/text_content"
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:fontFamily="serif"
android:fontFamily="sans-serif"
android:paddingStart="@dimen/margin_extra_large"
android:paddingTop="@dimen/margin_large"
android:paddingEnd="@dimen/margin_extra_large"
Expand Down
2 changes: 1 addition & 1 deletion WordPress/src/main/res/layout/note_block_comment_user.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/margin_medium"
android:background="?android:selectableItemBackground"
android:fontFamily="serif"
android:fontFamily="sans-serif"
android:paddingBottom="@dimen/margin_medium"
android:textAppearance="?attr/textAppearanceBody1"
tools:text="Thanks for stopping by my blog! I hope to see you again. " />
Expand Down
Loading