Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sans serif for notifications #20202

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Feb 19, 2024

Fixes #20201

Description

This PR changes the typography of the note block within the comment notification detail view to be sans-serif instead of serif, for consistency with other parts of the app.

Screenshots:

Before After
note-block-serif note-block-sans

To Test:

  • Log into the app with an account that has notifications
  • Tap the notifications tab
  • Tap a comment notification to open a comment notification detail view
  • Observe that the font is sans-serif

Regression Notes

  1. Potential unintended areas of impact

Style changes in other areas of the app

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Code search for usage of the styles

  1. What automated tests I added (or what prevented me from doing so)

N/A


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 19, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20202-5468fd1
Commit5468fd1
Direct Downloadwordpress-prototype-build-pr20202-5468fd1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 19, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20202-5468fd1
Commit5468fd1
Direct Downloadjetpack-prototype-build-pr20202-5468fd1.apk
Note: Google Login is not supported on these builds.

@mkevins mkevins changed the title Use sans serif for notifications 🤖 Use sans serif for notifications Feb 19, 2024
@mkevins mkevins changed the title 🤖 Use sans serif for notifications Use sans serif for notifications Feb 19, 2024
@mkevins mkevins requested review from antonis and jarvislin February 19, 2024 08:31
@mkevins mkevins marked this pull request as ready for review February 19, 2024 08:32
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (12987f7) 40.14% compared to head (5468fd1) 40.14%.

Files Patch % Lines
...ess/android/ui/notifications/blocks/NoteBlock.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                        @@
##           feature/notifications_refresh_p1   #20202   +/-   ##
=================================================================
  Coverage                             40.14%   40.14%           
=================================================================
  Files                                  1469     1469           
  Lines                                 67784    67784           
  Branches                              11230    11230           
=================================================================
  Hits                                  27209    27209           
  Misses                                38080    38080           
  Partials                               2495     2495           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jarvislin jarvislin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating the font!

@mkevins mkevins merged commit 789a519 into feature/notifications_refresh_p1 Feb 19, 2024
22 checks passed
@mkevins mkevins deleted the issue/20201-use-sans-serif-for-notifications branch February 19, 2024 08:39
@mkevins
Copy link
Contributor Author

mkevins commented Feb 19, 2024

Thanks for reviewing Jarvis!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants