Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader IA] Show onboarding for users with no tags or dailyprompt tag only #20103

Conversation

thomashorta
Copy link
Contributor

Fixes #20091

Ignores the dailyprompt tag when checking for the subscribed tags to show the Discover Onboarding / Choose your interests (onboarding) screens.


To Test:

Requirements

Create a new account to run the test (dailyprompt tag auto-injected by default) or prepare an existing account by unsubscribing from all tags and subscribing only to dailyprompt tag.

Steps

  1. Install Jetpack and log in/sign up
  2. Go to Reader
  3. Go to Discover
  4. Verify the "Welcome" message with a "Get Started" button is shown
  5. Tap "Get Started"
  6. Verify the "Choose your interests" screen with the tag cloud shows up

Also, test that having no tags at all shows the Welcome screen and that having other tags doesn't show it.


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Added unit tests for the new scenario.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20103-2ce97ec
Commit2ce97ec
Direct Downloadjetpack-prototype-build-pr20103-2ce97ec.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20103-2ce97ec
Commit2ce97ec
Direct Downloadwordpress-prototype-build-pr20103-2ce97ec.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eeec540) 40.48% compared to head (2ce97ec) 40.48%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           feature/reader-ia   #20103   +/-   ##
==================================================
  Coverage              40.48%   40.48%           
==================================================
  Files                   1447     1447           
  Lines                  66788    66788           
  Branches               11030    11030           
==================================================
  Hits                   27036    27036           
  Misses                 37268    37268           
  Partials                2484     2484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@develric develric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @thomashorta 🙇 . Works as expected and code LGTM 👍 . I'm approving and merging it now. :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants