-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader IA] Show onboarding for users with no tags or dailyprompt tag only #20103
[Reader IA] Show onboarding for users with no tags or dailyprompt tag only #20103
Conversation
Generated by 🚫 dangerJS |
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/reader-ia #20103 +/- ##
==================================================
Coverage 40.48% 40.48%
==================================================
Files 1447 1447
Lines 66788 66788
Branches 11030 11030
==================================================
Hits 27036 27036
Misses 37268 37268
Partials 2484 2484 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @thomashorta 🙇 . Works as expected and code LGTM 👍 . I'm approving and merging it now.
Fixes #20091
Ignores the
dailyprompt
tag when checking for the subscribed tags to show the Discover Onboarding / Choose your interests (onboarding) screens.To Test:
Requirements
Create a new account to run the test (
dailyprompt
tag auto-injected by default) or prepare an existing account by unsubscribing from all tags and subscribing only todailyprompt
tag.Steps
Also, test that having no tags at all shows the Welcome screen and that having other tags doesn't show it.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: