[Reader] Improve content navigation and filtering #19978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rop-down-menu-not-being-shown [Reader IA] Fix RTL drop-down menu not being shown
…-filter-enter-anim [Reader IA] Make Filter slide in/out horizontally when animating
…-update-selected-content-stream-based-on-menu-item [Reader IA] Update selected content stream based on menu item
…fetching-new-pages
…-list-not-fetching-new-pages [Reader] Fix tag posts list paging
…der Following tab" This reverts commit 530bb5c. This revert is needed since now we do rely on information from the Following blogs on the Following feed due to the new filters UI on the Top Bar.
…-show-onboarding-for-new-reader-users [Reader IA] Show onboarding for users with no tags or dailyprompt tag only
…-bug-reset-when-changing-tabs [Reader IA] Prevent unwanted Reader feed state reset when reopening Reader tab
The added code tries to wait until the topBarUiState is not null by polling for its data for a few times. If it's still null it simply doesn't run the code, to avoid calling topbar updates that should only happen if there is already a top bar visible. If it's not null after that check (normal scenario) then it calls the block and executes the logic.
Save information about the selected feed id and top bar filter ui state in the SavedInstanceState Bundle and recover it when the activity is destroyed due to system-initiated destruction (low-memory or "Don't keep activities" dev setting) to keep the experience consistent.
thomashorta
added
Do Not Merge
added 5 commits
February 2, 2024 18:36
Avoid breaking existing unit tests.
…p-navigation-disappear [Reader IA] Fix top navigation bar disappearing when system has low-memory
…ate-release-notes Updating the release notes.
…-comments-action-string [Reader] Change comment subscribe action label to "Follow"
thomashorta
removed
the
Do Not Merge
thomashorta
approved these changes
Feb 3, 2024
develric
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Do not merge this feature branch until all the task PRs are merged.
Feature branch for the Reader Navigation and Filtering Improvements Project
Internal ref: pcdRpT-506-p2
This feature branch contains code from PRs that were reviewed and tested individually, and
trunksync commits, so everything here is already Code Reviewed.Here is the list of PRs included in this branch:
To Test:
Since this feature branch includes several tested PRs (see section above) there are several changes to cover with testing, so it is easier to follow the Test Plan for the whole Reader Navigation and Filtering Improvements Project, which can be found at: p1706977111734119-slack-C05N140C8H5
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txtif necessary.UI Changes Testing Checklist: