Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader IA] Fix crash on Subfilter Sheet when rotating the device #20081

Merged

Conversation

thomashorta
Copy link
Contributor

Fixes #19991

Fixes the crash by using the same context as the bottom sheet (instead of trying to use an outdated scope that doesn't exist anymore) and making sure to remove the Dialog's onShowListener after executing the initialization code, to avoid it being called again (after rotation everything is recreated anyway so we shouldn't be calling the old bottom sheet).


To Test:

  • Tap on main dropdown menu and select Subscriptions
  • Tap on “Tags” pill, let the app open the bottom menu (do not select a tag yet)
  • Rotate the device
  • Verify the app doesn't crash anymore

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20081-7284c6c
Commit7284c6c
Direct Downloadjetpack-prototype-build-pr20081-7284c6c.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20081-7284c6c
Commit7284c6c
Direct Downloadwordpress-prototype-build-pr20081-7284c6c.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@thomashorta thomashorta changed the title Fix crash on Subfilter Sheet when rotating the device [Reader IA] Fix crash on Subfilter Sheet when rotating the device Jan 31, 2024
@thomashorta thomashorta merged commit 92df671 into feature/reader-ia Jan 31, 2024
21 of 26 checks passed
@thomashorta thomashorta deleted the issue/19991-reader-ia-crash-subfilter-sheet branch January 31, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants