Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravatar Library - Remove Okio dependency from WPAndroid #19946

Merged
merged 1 commit into from
Jan 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion WordPress/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,6 @@ dependencies {
implementation "com.github.chrisbanes:PhotoView:$chrisbanesPhotoviewVersion"
implementation "org.greenrobot:eventbus:$eventBusVersion"
implementation "org.greenrobot:eventbus-java:$eventBusVersion"
implementation "com.squareup.okio:okio:$squareupOkioVersion"
implementation "com.squareup.retrofit2:retrofit:$squareupRetrofitVersion"
implementation "org.apache.commons:commons-text:$apacheCommonsTextVersion"
implementation "com.airbnb.android:lottie:$lottieVersion"
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion WordPress/src/jetpack/assets/licenses.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ <h2>Additional Libraries</h2>
<li><a href="https://github.com/jukka/tagsoup">TagSoup</a>: Copyright 2002-2008, John Cowan</li>
<li><a href="https://github.com/Yalantis/uCrop">uCrop</a>: Copyright 2017, Yalantis</li>
<li><a href="https://github.com/xizzhu/simple-tool-tip">Simple Tool Tip</a>: Copyright 2016, Xizhi Zhu</li>
<li><a href="https://github.com/square/okio">okio/okhttp</a>: Copyright 2013 Square, Inc.</li>
<li><a href="https://github.com/greenrobot/EventBus">EventBus</a>: Copyright 2012-2016 Markus Junginger, greenrobot</li>
<li><a href="https://github.com/INDExOS/media-for-mobile">Mobile 4 Media</a>: Copyright 2016, INDExOS</li>
<li><a href="https://github.com/Tenor-Inc/tenor-android-core">Tenor Android Core</a>: Copyright 2017, Tenor Inc</li>
Expand Down
1 change: 0 additions & 1 deletion WordPress/src/main/assets/licenses.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ <h2>Additional Libraries</h2>
<li><a href="https://github.com/jukka/tagsoup">TagSoup</a>: Copyright 2002-2008, John Cowan</li>
<li><a href="https://github.com/Yalantis/uCrop">uCrop</a>: Copyright 2017, Yalantis</li>
<li><a href="https://github.com/xizzhu/simple-tool-tip">Simple Tool Tip</a>: Copyright 2016, Xizhi Zhu</li>
<li><a href="https://github.com/square/okio">okio/okhttp</a>: Copyright 2013 Square, Inc.</li>
<li><a href="https://github.com/greenrobot/EventBus">EventBus</a>: Copyright 2012-2016 Markus Junginger, greenrobot</li>
<li><a href="https://github.com/INDExOS/media-for-mobile">Mobile 4 Media</a>: Copyright 2016, INDExOS</li>
<li><a href="https://github.com/Tenor-Inc/tenor-android-core">Tenor Android Core</a>: Copyright 2017, Tenor Inc</li>
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ ext {
lottieVersion = '6.1.0'
philjayMpAndroidChartVersion = 'v3.1.0'
squareupKotlinPoetVersion = '1.6.0'
squareupOkioVersion = '3.6.0'
squareupRetrofitVersion = '2.9.0'
uCropVersion = '2.2.8'
zendeskVersion = '5.1.2'
Expand Down
27 changes: 5 additions & 22 deletions docs/test_instructions_per_dependency_update.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,19 +55,17 @@ rather than strict requirements.
4. [PlayServicesAuth](#playservicesauth)
5. [PlayServicesCoreScanner](#playservicescodescanner)
6. [PlayReview](#playreview)
5. Network
1. [Okio](#okio)
6. Tool
5. Tool
1. [Zendesk](#zendesk)
2. [JSoup](#jsoup)
7. Other Core
6. Other Core
1. [AutoService](#autoservice)
2. [KotlinPoet](#kotlinpoet)
8. Other UI
7. Other UI
1. [Lottie](#lottie)
2. [UCrop](#ucrop)
9. [Smoke Test](#smoke-test)
10. [Special](#special)
8. [Smoke Test](#smoke-test)
9. [Special](#special)

ℹ️ Every test instruction should be prefixed with one of the following:
- [JP/WP] This test applies to both, the `Jetpack` and `WordPress` apps.
Expand Down Expand Up @@ -435,21 +433,6 @@ Step.3:

-----

### Okio [[squareupOkioVersion](https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/build.gradle)] <a name="okio"></a>

<details>
<summary>1. [JP/WP] Me Screen [GravatarApi.java + StreamingRequest.java]</summary>

- Go to `Me` tab.
- From the `Me` screen you are in, click on your profile's icon (`CHANGE PHOTO`).
- Choose an image and wait for the `Edit Photo` screen to appear.
- Crop the image and click the `done` menu option (top right).
- Verify the image is updated accordingly.

</details>

-----

### Zendesk [[zendeskVersion](https://github.com/wordpress-mobile/WordPress-Android/blob/trunk/build.gradle)] <a name="zendesk"></a>

<details>
Expand Down
Loading