Gravatar Library - Remove Okio dependency from WPAndroid #19946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we've moved the Gravatar update to an external library. We no longer need the Okio dependency in this project.
|
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:analytics
| \--- com.automattic:Automattic-Tracks-Android:3.3.0
| \--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.11.0
-| \--- com.squareup.okio:okio:3.2.0 -> 3.6.0
-| \--- com.squareup.okio:okio-jvm:3.6.0
-| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10
+| \--- com.squareup.okio:okio:3.2.0 -> 3.3.0
+| \--- com.squareup.okio:okio-jvm:3.3.0
+| +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.0 -> 1.9.10 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.8.0 -> 1.9.10
+--- project :libs:editor
| \--- com.facebook.react:react-android:0.71.11
-| \--- com.squareup.okio:okio:2.9.0 -> 3.6.0 (*)
+| \--- com.squareup.okio:okio:2.9.0 -> 3.3.0 (*)
++--- com.airbnb.android:lottie:6.1.0
+| \--- com.squareup.okio:okio:{require 1.17.5; reject _} -> 3.3.0 (*)
-+--- com.squareup.okio:okio:3.6.0 (*)
-+--- com.airbnb.android:lottie:6.1.0
-| \--- com.squareup.okio:okio:{require 1.17.5; reject _} -> 3.6.0 (*)
+--- io.coil-kt:coil-compose:2.4.0
| \--- io.coil-kt:coil-compose-base:2.4.0
| \--- io.coil-kt:coil-base:2.4.0
-| \--- com.squareup.okio:okio:3.3.0 -> 3.6.0 (*)
+| \--- com.squareup.okio:okio:3.3.0 (*)
Please review and act accordingly
|
Generated by 🚫 dangerJS |
hamorillo
force-pushed
the
hamorillo/remove-unnecessary-okio
branch
from
3010ffa to
f59b4de
Compare
Generated by 🚫 Danger |
maxme
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Test:
We've moved the Gravatar upload to an external library. We no longer need the Okio dependency in this project. Verify that you can still upload new avatars.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)