Configure Codecov #19936
Merged
Configure Codecov #19936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was applied only to the merged report.
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19936-ea9cb25 | |
| Commit | ea9cb25 | |
| Direct Download | jetpack-prototype-build-pr19936-ea9cb25.apk |
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr19936-ea9cb25 | |
| Commit | ea9cb25 | |
| Direct Download | wordpress-prototype-build-pr19936-ea9cb25.apk |
This reverts commit a4b61e7.
This reverts commit 142c92d.
This reverts commit 2c1f5d8.
To disable PR checks on GitHub. `max_report_age: off` has this context: woocommerce/woocommerce-android#6251
Generated by 🚫 dangerJS |
tiagomar
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Thanks for working on this, @wzieba! 🙇
I could visit the dashboard and confirm there was coverage reported for WordPress, :libs:image-editor and :libs:processors.
comments on each PR reporting code coverage diff(...)
I assume this would only be visible after being merged to trunk.
Why use CODECOV_TOKEN if WordPress-Android is a public repository?
Thanks for being one step ahead and for sharing the context! 🙇
Everything looks good to me. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates Codecov. By this, we'll have:
To Test:
WordPress:libs:image-editor:libs:processorsIt's double-check. From what I've browsed, all seems fine. Also, each job on Buildkite reports successful report upload to Codecov.
Decission log
Why specify the report file directly?
Codecov couldn't find reports if they were named differently than
report.xml. So initially, it worked only for a JVM module (:lib:processors) but didn't work for e.g.WordPress, because the report file is namedreportWordpressVanillaRelease.xml.Why use
CODECOV_TOKENif WordPress-Android is a public repository?It's possible to use Codecov uploader without specifing a token if repository is open source. This approach is flaky though and results with often upload failures. Details are available in this comment and thread: codecov/codecov-action#557 (comment)