Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply code coverage exclusion rules to all projects #19956

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

wzieba
Copy link
Contributor

@wzieba wzieba commented Jan 16, 2024

Description

This minor PR corrects a mistake introduced in #19936 . As the merged Kover report is configured in the rootProject, we can't configure exclusions using subprojects as it specifically filters out the rootProject.

Instead of allprojects should be used.

Test

Before: report from running koverHtmlReport Gradle task contains hilt_aggregated_deps package

After: report from running koverHtmlReport Gradle task does not contain hilt_aggregated_deps package

@wzieba wzieba added the Tooling label Jan 16, 2024
@wzieba wzieba added this to the 24.1 milestone Jan 16, 2024
@wzieba wzieba requested a review from tiagomar January 16, 2024 10:01
@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19956-46d7820
Commit46d7820
Direct Downloadjetpack-prototype-build-pr19956-46d7820.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19956-46d7820
Commit46d7820
Direct Downloadwordpress-prototype-build-pr19956-46d7820.apk
Note: Google Login is not supported on these builds.

@wzieba wzieba enabled auto-merge January 16, 2024 10:38
Copy link
Contributor

@tiagomar tiagomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@wzieba wzieba merged commit 52f85bf into trunk Jan 16, 2024
19 of 22 checks passed
@wzieba wzieba deleted the fix/kover-merged-report-exclusions branch January 16, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants