-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Implement analytics events considering new filter UI #19929
[Reader] Implement analytics events considering new filter UI #19929
Conversation
Generated by 🚫 Danger |
Found 1 violations: The PR caused the following dependency changes:+\--- me.saket.cascade:cascade-compose:2.3.0
+ +--- androidx.activity:activity-compose:1.7.2 -> 1.8.0 (*)
+ +--- androidx.compose.ui:ui:1.5.2 -> 1.5.3 (*)
+ +--- androidx.compose.ui:ui-tooling:1.5.2 -> 1.5.3 (*)
+ +--- androidx.compose.foundation:foundation:1.5.2 -> 1.5.3 (*)
+ +--- androidx.compose.material3:material3:1.1.2 (*)
+ \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.10 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! There are a couple of warnings, but once they're fixed, we can proceed with shipping it.
Thanks for the review, @daniloercoli Since we're working in a feature branch I usually don't assign the PRs to a milestone, and instead only the feature branch PR when we open it. The reason for that is because AFAIU apps infrastructure team uses the milestone to understand which PRs are part the new version. If we, for example, add the next version milestone (let's say TL;DR I don't usually assign a milestone for PRs not targeting We call this one a |
@daniloercoli I think I got it: initially I was targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #19925
To Test:
1 - Install JP and sign in
2 - Open
Reader
3 - Select
Subscriptions
in the drop-down menu4 - Tap the blogs chip: the following event should be tracked with the new parameter
"source"
:5 - Dismiss the blogs chip and tap the tags chip: the following event should be tracked with the new parameter
"source"
:6 - Tap any tag in the bottom sheet: the following event should be tracked:
7- Tap "x" to clear the filter: the following even should be tracked:
8- You should NOT see
reader_filter_sheet_item_selected
being tracked when the filter is cleared;9 - Repeat steps 6-8 using a blog instead of tag.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
SubFilterViewModelTest
.PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist: