Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reader IA][Search] Hook Search top bar action to existing functionality #19927

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

thomashorta
Copy link
Contributor

Fixes #19923

The search action in the new Reader top bar was not working so far, so this PR hooks it to the existing logic to show/hide it when the search feature is supported (logged into WPcom account or not) and to open the existing Search screen when tapped.


To Test:

Search action visibility

The search action should only show up for users logged into Jetpack with a WPcom account, so it's hidden for users logged with self-hosted sites.

19923-reader-ia-search-hidden-self-hosted.mp4

Hidden

  1. Log into Jetpack with a self-hosted site
  2. Go to Reader
  3. Verify the search action icon is not shown in the top bar for any feeds

Showing

  1. Log into Jetpack with a WPcom account
  2. Go to Reader
  3. Verify the search action icon is shown in the top bar for all feeds

Search action opening Search screen

Tapping the search action should redirect the user to the existing Reader Search feature.

19923-reader-ia-search-action.mp4
  1. Log into Jetpack with a WPcom account
  2. Go to Reader
  3. Tap the search action icon in the top bar
  4. Verify it opens the existing Search screen

Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • None yet (unit tests for the top bar will be done in a different PR)

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

UI Changes Testing Checklist:

N/A

  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

* Show/hide if search is supported
* Open Reader search screen
@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19927-300b246
Commit300b246
Direct Downloadjetpack-prototype-build-pr19927-300b246.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19927-300b246
Commit300b246
Direct Downloadwordpress-prototype-build-pr19927-300b246.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@RenanLukas RenanLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @thomashorta

It's working as expected and code LGTM :shipit:

@thomashorta thomashorta merged commit 752591e into feature/reader-ia Jan 12, 2024
19 checks passed
@thomashorta thomashorta deleted the issue/19923-reader-ia-search-action branch January 12, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants