[Reader IA][Search] Hook Search top bar action to existing functionality #19927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19923
The search action in the new Reader top bar was not working so far, so this PR hooks it to the existing logic to show/hide it when the search feature is supported (logged into WPcom account or not) and to open the existing Search screen when tapped.
To Test:
Search action visibility
The search action should only show up for users logged into Jetpack with a WPcom account, so it's hidden for users logged with self-hosted sites.
19923-reader-ia-search-hidden-self-hosted.mp4
Hidden
Showing
Search action opening Search screen
Tapping the search action should redirect the user to the existing Reader Search feature.
19923-reader-ia-search-action.mp4
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.UI Changes Testing Checklist:
N/A