Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA Workflow for validating issues #19918

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Jan 11, 2024

This PR reimplements our current Issues check done in Peril with a GHA workflow. It uses the reusable workflow implemented on Automattic/dangermattic#31.

How to test

This is a bit hard to test as GHA Issue events are only triggered for workflows already on the main branch, and a complete test can be done only once this PR is merged.

I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: https://github.com/iangmaia/woocommerce-android/

@iangmaia iangmaia requested a review from a team January 11, 2024 12:16
@iangmaia iangmaia self-assigned this Jan 11, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 11, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr19918-eb9a63e
Commiteb9a63e
Direct Downloadwordpress-prototype-build-pr19918-eb9a63e.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 11, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr19918-eb9a63e
Commiteb9a63e
Direct Downloadjetpack-prototype-build-pr19918-eb9a63e.apk
Note: Google Login is not supported on these builds.

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit hard to test as GHA Issue events are only triggered for workflows already on the main branch, and a complete test can be done only once this PR is merged.

Approving on the basis of having tested the workflow via a dedicated repo, Automattic/dangermattic#31 (review), and tracking the note about pointing to trunk till we'll have a v1, Automattic/simplenote-ios#1547 (comment)

:shipit:

@iangmaia iangmaia force-pushed the iangmaia/gha-labels-on-issues-check branch from bdb5fc3 to eb9a63e Compare February 12, 2024 17:07
@iangmaia iangmaia merged commit ca3d8d8 into trunk Feb 12, 2024
21 checks passed
@iangmaia iangmaia deleted the iangmaia/gha-labels-on-issues-check branch February 12, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants