Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA Workflow for validating issues #22372

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Conversation

iangmaia
Copy link
Contributor

@iangmaia iangmaia commented Jan 11, 2024

This PR reimplements our current Issues check done in Peril with a GHA workflow. It uses the reusable workflow implemented on Automattic/dangermattic#31.

How to test

This is a bit hard to test as GHA Issue events are only triggered for workflows already on the main branch, and a complete test can be done only once this PR is merged.

I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: https://github.com/iangmaia/woocommerce-android/

@iangmaia iangmaia added the Tooling Build, Release, and Validation Tools label Jan 11, 2024
@iangmaia iangmaia requested a review from a team January 11, 2024 12:07
@iangmaia iangmaia self-assigned this Jan 11, 2024
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 11, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22372-1152d50
Version24.2
Bundle IDorg.wordpress.alpha
Commit1152d50
App Center BuildWPiOS - One-Offs #8755
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 11, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22372-1152d50
Version24.2
Bundle IDcom.jetpack.alpha
Commit1152d50
App Center Buildjetpack-installable-builds #7782
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@iangmaia iangmaia force-pushed the iangmaia/gha-labels-on-issues-check branch from c54d15a to f9f9e09 Compare January 11, 2024 19:18
@mokagio
Copy link
Contributor

mokagio commented Jan 12, 2024

@iangmaia

I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: iangmaia/woocommerce-android

Thank you for setting this up. Could I have access to add labels? I tried to but my user doesn't see the labels field.

@iangmaia
Copy link
Contributor Author

@iangmaia

I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: iangmaia/woocommerce-android

Thank you for setting this up. Could I have access to add labels? I tried to but my user doesn't see the labels field.

Just sent an invite!

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@mokagio
Copy link
Contributor

mokagio commented Jan 18, 2024

@iangmaia just touching base on this PR. As you might have seen, I got access to the test repo, reviewed, and approved Automattic/dangermattic#31 👏

I think before merging this and reviewing the related PRs in the other projects, we should wait for Automattic/dangermattic#31 to land. That would also allow us to update the workflow.

- uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@iangmaia/gha-labels-on-issues-check
+ uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml

For my reference, here's a list of related PRs based on my notifications list on GitHub:

@iangmaia iangmaia force-pushed the iangmaia/gha-labels-on-issues-check branch from f9f9e09 to c3140d8 Compare January 19, 2024 18:50
@iangmaia iangmaia force-pushed the iangmaia/gha-labels-on-issues-check branch from c3140d8 to 1152d50 Compare February 12, 2024 17:06
@iangmaia iangmaia requested a review from mokagio February 13, 2024 13:53
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping @iangmaia

Isn't it funny that I reviewed all the PRs I listed in my comment here, then forgot about the one that contained the list 😓

Approving on the basis of having tested the workflow via a dedicated repo, Automattic/dangermattic#31 (review), and tracking the note about pointing to trunk till we'll have a v1, Automattic/simplenote-ios#1547 (comment)

:shipit:

@iangmaia iangmaia merged commit 4f2cdc3 into trunk Feb 14, 2024
23 checks passed
@iangmaia iangmaia deleted the iangmaia/gha-labels-on-issues-check branch February 14, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants