-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA Workflow for validating issues #22372
Conversation
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
Generated by 🚫 dangerJS |
c54d15a
to
f9f9e09
Compare
Thank you for setting this up. Could I have access to add labels? I tried to but my user doesn't see the labels field. |
Just sent an invite! |
Generated by 🚫 Danger |
@iangmaia just touching base on this PR. As you might have seen, I got access to the test repo, reviewed, and approved Automattic/dangermattic#31 👏 I think before merging this and reviewing the related PRs in the other projects, we should wait for Automattic/dangermattic#31 to land. That would also allow us to update the workflow. - uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@iangmaia/gha-labels-on-issues-check
+ uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml For my reference, here's a list of related PRs based on my notifications list on GitHub:
|
f9f9e09
to
c3140d8
Compare
c3140d8
to
1152d50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping @iangmaia
Isn't it funny that I reviewed all the PRs I listed in my comment here, then forgot about the one that contained the list 😓
Approving on the basis of having tested the workflow via a dedicated repo, Automattic/dangermattic#31 (review), and tracking the note about pointing to trunk
till we'll have a v1, Automattic/simplenote-ios#1547 (comment)
This PR reimplements our current Issues check done in Peril with a GHA workflow. It uses the reusable workflow implemented on Automattic/dangermattic#31.
How to test
This is a bit hard to test as GHA Issue events are only triggered for workflows already on the main branch, and a complete test can be done only once this PR is merged.
I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: https://github.com/iangmaia/woocommerce-android/