Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] refactor: artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경 (#811) #818

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

seokjin8678
Copy link
Collaborator

@seokjin8678 seokjin8678 commented Mar 28, 2024

📌 관련 이슈

✨ PR 세부 내용

말 그대로 artist 테스트 패키지에서 생성자로 엔티티를 생성하던 것을 픽스쳐를 사용하여 생성하도록 변경했습니다!

@seokjin8678 seokjin8678 added BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업 🧪 테스트 테스트에 관련된 작업 labels Mar 28, 2024
@seokjin8678 seokjin8678 self-assigned this Mar 28, 2024
@github-actions github-actions bot requested review from BGuga, carsago and xxeol2 March 28, 2024 07:39
Copy link

github-actions bot commented Mar 28, 2024

Test Results

186 files  186 suites   30s ⏱️
638 tests 638 ✅ 0 💤 0 ❌
651 runs  651 ✅ 0 💤 0 ❌

Results for commit 7c80a9f.

♻️ This comment has been updated with latest results.

@seokjin8678 seokjin8678 changed the title [BE] artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경 (#811) [BE] refactor: artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경 (#811) Mar 28, 2024
Copy link
Collaborator

@carsago carsago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!

# Conflicts:
#	backend/src/test/java/com/festago/artist/application/integration/ArtistDetailV1QueryServiceIntegrationTest.java
@seokjin8678 seokjin8678 merged commit 6ec5a07 into dev Apr 3, 2024
3 checks passed
@seokjin8678 seokjin8678 deleted the feat/#811 branch April 3, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업 🧪 테스트 테스트에 관련된 작업
Projects
None yet
2 participants