Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경한다. #811

Closed
Tracked by #810
seokjin8678 opened this issue Mar 25, 2024 · 0 comments · Fixed by #818
Closed
Tracked by #810

[BE] artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경한다. #811

seokjin8678 opened this issue Mar 25, 2024 · 0 comments · Fixed by #818
Assignees
@seokjin8678
Labels
BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업 🧪 테스트 테스트에 관련된 작업

Comments

@seokjin8678
Copy link
Collaborator

No description provided.

@seokjin8678 seokjin8678 mentioned this issue Mar 25, 2024
Closed
5 tasks
@seokjin8678 seokjin8678 changed the title artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경한다. [BE] artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경한다. Mar 25, 2024
@seokjin8678 seokjin8678 added BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업 🧪 테스트 테스트에 관련된 작업 labels Mar 25, 2024
@seokjin8678 seokjin8678 self-assigned this Mar 26, 2024
@seokjin8678 seokjin8678 linked a pull request Mar 28, 2024 that will close this issue
[BE] refactor: artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경 (#811) #818
Merged
@seokjin8678 seokjin8678 mentioned this issue Mar 28, 2024
Merged
seokjin8678 added a commit that referenced this issue Apr 3, 2024
@seokjin8678
Merge branch 'dev' into feat/#811
71e1a77 
# Conflicts:
#	backend/src/test/java/com/festago/artist/application/integration/ArtistDetailV1QueryServiceIntegrationTest.java
seokjin8678 added a commit that referenced this issue Apr 3, 2024
@seokjin8678
[BE] refactor: artist 테스트 패키지에서 엔티티 생성을 픽스쳐를 사용하여 생성하도록 변경 (#811) (#818)
6ec5a07 
* test: 엔티티 생성 Fixture 사용하도록 변경

* test: ArtistCommand 통합 테스트 삭제

- 단위 테스트로 충분한 검증이 가능하므로 제거

* test: Controller 단위 테스트 status만 검증하도록 수정

* test: Command Service 검증 명확하게 변경

- isPresent 사용
- backgroundImageUrl 검증 추가

* fix: 머지 충돌 해결
@github-project-automation github-project-automation bot moved this from Todo to Done in 2023-festa-go Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seokjin8678 seokjin8678

Labels
BE 백엔드에 관련된 작업 ⚙️ 리팩터링 리팩터링에 관련된 작업 🧪 테스트 테스트에 관련된 작업
Projects
2023-festa-go
Status: Done
Milestone
No milestone
1 participant
@seokjin8678