Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gobject-introspection: rebuild against 3.13 #37393

Closed
wants to merge 3 commits into from

Conversation

sil2100
Copy link
Member

@sil2100 sil2100 commented Dec 18, 2024

We see a FTBFS of at-spi2-core. The main reason is that gobject-introspection was built against 3.12, and the build can't work with 3.13. Rebuild it and also switch to using the py-versioned versions of packages.

Fixes: #37369

Related: #37197

Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
@sil2100 sil2100 requested review from smoser, dannf and murraybd December 18, 2024 11:15
Copy link
Member

@smoser smoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. please feel free to ask for clarification, or to disagree.

- py3-setuptools
- py${{vars.py-version}}-build-base
- py${{vars.py-version}}-packaging
- py${{vars.py-version}}-setuptools
- python3
- python3-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop python3 and python3-dev here. they're either already covered or potentially bring the wrong thing in.

actually, i think just do py${{vars.py-version}}-build-base-dev and you'll get what you need.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I need to one day sit down and just browse through all the packages available for the Python multi-versioned efforts. Forgot about -build-base-dev, convenient!

@@ -76,7 +80,7 @@ subpackages:
- gobject-introspection
- libtool
- posix-libc-utils
- py3-setuptools
- py${{vars.py-version}}-setuptools
- python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop python3 here. melange will add the necessary depends for it. (on python-3.13-base).

@murraybd
Copy link
Member

murraybd commented Dec 18, 2024

I have a much worse PR in #37370 but there is one thing I was adding that is missed here. There is a binary g-ir-scanner which is not able to run because a runtime dependency on python3 did not exist.

I did some experimenting using your PR and adding python3.13 as a run time dependency but that did not resolve the issue because the shbang in g-ir-scanner only ever has python.

(20/20) Installing gobject-introspection (1.82.0-r2)
OK: 77 MiB in 34 packages
2664dae60eac:/work/packages# head -n1 /usr/bin/g-ir-scanner 
#!/usr/bin/env python3

The point being if you continue working on this please sort out getting g-ir-scanner to work. Thanks!

@dannf
Copy link
Member

dannf commented Dec 19, 2024

I have a much worse PR in #37370 but there is one thing I was adding that is missed here. There is a binary g-ir-scanner which is not able to run because a runtime dependency on python3 did not exist.

I did some experimenting using your PR and adding python3.13 as a run time dependency but that did not resolve the issue because the shbang in g-ir-scanner only ever has python.

(20/20) Installing gobject-introspection (1.82.0-r2)
OK: 77 MiB in 34 packages
2664dae60eac:/work/packages# head -n1 /usr/bin/g-ir-scanner 
#!/usr/bin/env python3

The point being if you continue working on this please sort out getting g-ir-scanner to work. Thanks!

This package has a build-time config for the python interpreter - but even if you explicitly set it to python3.13, it will still shave the .13 off in the shebang. I don't think python-as-wrapper, would help here because it explicitly mangles the path, but I could be wrong.

I submitted this upstream to add a shebang option:
https://gitlab.gnome.org/GNOME/gobject-introspection/-/merge_requests/510

For now, we may just need to do a sed of the shebangs in the destdir.

…ython3 shebang until proper support for a shebang option lands.

Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
@sil2100 sil2100 requested a review from smoser December 19, 2024 11:52
@smoser
Copy link
Member

smoser commented Dec 19, 2024

For now, we may just need to do a sed of the shebangs in the destdir.

we should have a pipeline like below. There are a lot of places where we do shbang rewrites and all very inconsistently.

uses: shbang/edit
with:
  # matches match whole line (^<match>$), the ^ and $ added.
  matches: ".*python3"
  new: "/usr/bin/python${{vars.py-version}}"

@smoser
Copy link
Member

smoser commented Dec 19, 2024

#37500 . i'm going to close this. Please feel free to re-open if I should not have.

@smoser smoser closed this Dec 19, 2024
@sil2100 sil2100 deleted the gobject-introspection-py3.13 branch December 19, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

at-spi2-core fails to build on amd64
4 participants