-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gobject-introspection: rebuild against 3.13 #37393
Conversation
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. please feel free to ask for clarification, or to disagree.
gobject-introspection.yaml
Outdated
- py3-setuptools | ||
- py${{vars.py-version}}-build-base | ||
- py${{vars.py-version}}-packaging | ||
- py${{vars.py-version}}-setuptools | ||
- python3 | ||
- python3-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop python3
and python3-dev
here. they're either already covered or potentially bring the wrong thing in.
actually, i think just do py${{vars.py-version}}-build-base-dev
and you'll get what you need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I need to one day sit down and just browse through all the packages available for the Python multi-versioned efforts. Forgot about -build-base-dev
, convenient!
gobject-introspection.yaml
Outdated
@@ -76,7 +80,7 @@ subpackages: | |||
- gobject-introspection | |||
- libtool | |||
- posix-libc-utils | |||
- py3-setuptools | |||
- py${{vars.py-version}}-setuptools | |||
- python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop python3
here. melange will add the necessary depends for it. (on python-3.13-base).
I have a much worse PR in #37370 but there is one thing I was adding that is missed here. There is a binary I did some experimenting using your PR and adding python3.13 as a run time dependency but that did not resolve the issue because the shbang in
The point being if you continue working on this please sort out getting |
This package has a build-time config for the python interpreter - but even if you explicitly set it to I submitted this upstream to add a shebang option: For now, we may just need to do a |
…ython3 shebang until proper support for a shebang option lands. Signed-off-by: Łukasz 'sil2100' Zemczak <[email protected]>
we should have a pipeline like below. There are a lot of places where we do shbang rewrites and all very inconsistently. uses: shbang/edit
with:
# matches match whole line (^<match>$), the ^ and $ added.
matches: ".*python3"
new: "/usr/bin/python${{vars.py-version}}" |
#37500 . i'm going to close this. Please feel free to re-open if I should not have. |
We see a FTBFS of
at-spi2-core
. The main reason is thatgobject-introspection
was built against 3.12, and the build can't work with 3.13. Rebuild it and also switch to using the py-versioned versions of packages.Fixes: #37369
Related: #37197