Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a disabled test of g-ir-scanner #38514

Closed
wants to merge 1 commit into from
Closed

Add a disabled test of g-ir-scanner #38514

wants to merge 1 commit into from

Conversation

murraybd
Copy link
Member

The test currently fails as detailed in #37393 (comment) but we don't want to lose track of the fact that we should be testing g-ir-scanner so let's add it as a comment.

dannf
dannf reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@dannf dannf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @smoser fixed this test in commit 4780497. It exists earlier in the pipeline uncommented, and WFM :)

@murraybd
Copy link
Member Author

Wow, my bad.

@murraybd murraybd closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannf dannf dannf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murraybd @dannf