Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue with Invalid Token Message | Simplify OTP Credentials Controller #95

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Fix Issue with Invalid Token Message | Simplify OTP Credentials Controller #95

merged 4 commits into from
Sep 21, 2024

Commits on Sep 19, 2024

  1. add support for :now option to "otp_set_flash_message" method (follow… 

    …s devise "set_flash_message");
    @strouptl
    strouptl committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    454c6ad View commit details
    Browse the repository at this point in the history

  2. update flash message for invalid token to render immediately within "… 

    …update" action;
    @strouptl
    strouptl committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    193978c View commit details
    Browse the repository at this point in the history

  3. update test specs to ensure correct display of blank/invalid token fl… 

    …ash messages, and to ensure that they do not display after a successful authentication;
    @strouptl
    strouptl committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    a883aaa View commit details
    Browse the repository at this point in the history

  4. update both blank and invalid OTP authentication attempts to render :… 

    …show action for consistency; simplify condition for setting flash message;
    @strouptl
    strouptl committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    61bc8bc View commit details
    Browse the repository at this point in the history