Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue with Invalid Token Message | Simplify OTP Credentials Controller #95

Merged
merged 4 commits into from
Sep 21, 2024

Conversation

strouptl
Copy link
Contributor

Description: This PR fixes the Issue with Invalid Token message (#94), and simplifies the OTP Credentials controller to handle both blank and invalid tokens the same way.

Changes:

  • Add support for displaying flash messages immediately via "flash.now" to otp_set_flash_message method (matching with the devise "set_flash_message" method)
  • Update the OTP Credentials controller to handle both blank and failed tokens the same way (render "show" action rather than redirect), and to display the flash message immediately
  • Add tests to confirm resolution

Resources:

  • Devise's "set_flash_message" method (link)

…ash messages, and to ensure that they do not display after a successful authentication;
…show action for consistency; simplify condition for setting flash message;
@strzibny strzibny merged commit a75f920 into wmlele:master Sep 21, 2024
4 checks passed
@strouptl strouptl deleted the invalid_token_message branch November 19, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants