Cleanup "scoped" modifiers and h2 styling #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moiikana
force-pushed
the
fix-scoped-style
branch
4 times, most recently
from
d27dfb5
to
74267f3
Compare
- the scoped modifier influences how css is compiled and should not be used - remove empty style tags that weren't used (cleanup)
moiikana
force-pushed
the
fix-scoped-style
branch
from
0d2c863
to
7f66f04
Compare
moiikana
changed the title
moiikana
force-pushed
the
fix-scoped-style
branch
from
7f66f04
to
918143b
Compare
Sperling-0
approved these changes
Oct 22, 2024
Abban
requested changes
Oct 22, 2024
Abban
approved these changes
Oct 23, 2024
- while adding the new iban calculator a global css change on h2 slipped in that influenced the style on the confirmation page - change the h2 headline to h3 because it is nested inside a context that has an h2 header this fixes https://phabricator.wikimedia.org/T377833
moiikana
force-pushed
the
fix-scoped-style
branch
from
918143b
to
346da72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T377833