Skip to content

Commit

Permalink
Fix global headline styling
Browse files Browse the repository at this point in the history
- while adding the new iban calculator a global css change on h2 slipped in that
influenced the style on the confirmation page
- change the h2 headline to h3 because it is nested inside a context that has an h2 header

this fixes https://phabricator.wikimedia.org/T377833
  • Loading branch information
moiikana committed Oct 22, 2024
1 parent 556ba1f commit 918143b
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions src/components/shared/IbanFields.vue
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
<ScrollTarget target-id="iban-calculator-scroll-target"/>

<div class="iban-calculator-content">
<h2 class="icon-title">
<h3 class="icon-title">
<BankIcon/> {{ $t( 'donation_form_iban_calculator_title' ) }}
</h2>
</h3>

<button class="iban-calculator-close" @click.prevent="showCalculator = false" aria-controls="iban-calculator">
<span class="is-sr-only">{{ $t( 'close' ) }}</span>
Expand Down Expand Up @@ -375,17 +375,17 @@ watch( () => store.state.bankdata.values.iban, ( newIban: string ) => {
}
}
}
}
h2.icon-title {
padding: map.get(units.$spacing, 'small') 0 0 1.5rem;
margin: 0 map.get(units.$spacing, 'small');
font-size: 18px;
line-height: 25px;
h3.icon-title {
padding: map.get(units.$spacing, 'small') 0 0 1.5rem;
margin: 0 map.get(units.$spacing, 'small');
font-size: 18px;
line-height: 25px;
svg {
float: left;
margin: 4px 0 0 -1.5rem;
svg {
float: left;
margin: 4px 0 0 -1.5rem;
}
}
}
Expand Down

0 comments on commit 918143b

Please sign in to comment.