Handle mls-welcome events, creating necessary data with core-crypto #WPB-12154 #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Process event and check if new keyPackages are needed * Check if the conversation already exists when joining via commit * Check for key package replenishment during conversation.create and conversation.member.join * Add Mockito to test some simple replenishment and welcomeMessage in WireClientBase * Release on git tag instead of GitHub release, as other projects do * Fix Dokka not generating JavaDoc for CryptoMlsClient
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
5 tasks
Comment on lines
+4
to
+6
| workflow_dispatch: | ||
| release: | ||
| types: [ published ] |
| @@ -107,16 +117,22 @@ protected void handleMessage(UUID eventId, Payload payload, WireClient client) t | |||
| Logger.debug("conversation.create: bot: %s", botId); | |||
|
|
|||
| systemMessage = getSystemMessage(eventId, payload); | |||
| Integer otherMembers = PREKEYS_DEFAULT_REPLENISH; | |||
There was a problem hiding this comment.
the naming suggests a list of Member, if possible would be great to have another naming, maybe something like preKeysSize or preKeysCount but also super open to suggestions
There was a problem hiding this comment.
Changed the name of the variable. You also made me realize that I can skip proteus or MLS key replenishment in some cases, so I changed that
* Replenish only the needed keys on conversation.create * Minor refactoring
alexandreferris
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
MLS is supported for previous conversations, but not new ones received through mls-welcome event
Solutions
Add mld-welcome handling
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.