Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(add-exceptions-when-mls-handling-fails) #WPB-12152 #18

Conversation

alexandreferris
Copy link
Contributor

  • Update Helium to 1.5.1
  • Update Xenon to 1.7.1
  • Adjust wrong used http response on isMlsEnabled
  • Add proper handling and throwing of exception for:
  • uploadClientPublicKey
  • uploadClientKeyPackages
  • getConversationGroupInfo
  • getConversationGroupInfo
  • Ignore mls/ folder from .gitignore

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Some methods for MLS handling were not throwing exceptions correctly

Solutions

Add proper handling of throwing exceptions

Dependencies (Optional)

This PR is to be merged after release of Xenon 1.7.1

Needs releases with:

Testing

Tests are done one level above (Legalhold)

* Update Helium to 1.5.1
* Update Xenon to 1.7.1
* Adjust wrong used http response on isMlsEnabled
* Add proper handling and throwing of exception for:
 - uploadClientPublicKey
 - uploadClientKeyPackages
 - getConversationGroupInfo
 - getConversationGroupInfo
* Ignore mls/ folder from .gitignore
@alexandreferris alexandreferris requested a review from a team as a code owner November 19, 2024 15:38
@alexandreferris alexandreferris self-assigned this Nov 19, 2024
@echoes-hq echoes-hq bot added the echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud label Nov 19, 2024
Copy link

sonarcloud bot commented Nov 19, 2024

@alexandreferris alexandreferris merged commit b07c35a into master Nov 20, 2024
4 checks passed
@alexandreferris alexandreferris deleted the chore/throw-exceptions-on-mls-key-package-and-public-key branch November 20, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: federation-wire-cloud Activate Federation with MLS on Wire Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants